Skip to content

fix(accordion): arrow alignment #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix(accordion): arrow alignment #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/_patterns/02-components/accordion/_accordion.variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@import "../../00-base/icons/icons.variables";
@import "../../00-base/icons/icons.helpers";

$accordion---paddingLeft: 46 !default;
$accordion---paddingLeft: $db-spacing-m !default;
$accordion---paddingRight: to-rem(
$pxValue: 16
) !default;
23 changes: 15 additions & 8 deletions source/_patterns/02-components/accordion/accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,16 @@
padding-right: $accordion---paddingRight;

summary {
@include icon(glyph(chevron-right), 24, "outline", $partial: $partial);
@include icon(
glyph(expand-more),
24,
"outline",
"after",
$partial: $partial
);
align-items: center;
display: flex;
justify-content: space-between;

padding-block: $db-spacing-sm;
// Negating the padding left for moving the element into that direction with the same measures
Expand All @@ -29,9 +36,9 @@
}

// Icon horizontal space
&::before {
--icon-margin-after: #{to-rem($pxValue: 8)};
margin-left: #{to-rem($pxValue: 14)};
&::after {
--icon-margin-before: #{to-rem($pxValue: 8)};
margin-right: #{to-rem($pxValue: 14)};
}

& + p {
Expand All @@ -40,7 +47,7 @@
}
// TODO: This might get simplified in the future with @nest
&[open] > summary {
&::before {
&::after {
content: glyph(expand-less);
}
}
Expand All @@ -56,7 +63,7 @@
font-weight: 700;
height: to-rem($pxValue: 56);

&::before {
&::after {
--icon-font-size: #{to-rem($pxValue: 32)};
}
}
Expand All @@ -78,7 +85,7 @@
// ToDo: This needs to get replaced by the correct variable
padding-block: 0.59375rem;

&::before {
&::after {
--icon-font-size: #{to-rem($pxValue: 20)};
--icon-margin-after: #{to-rem($pxValue: 6)};
margin-left: #{to-rem($pxValue: 6)};
Expand All @@ -96,7 +103,7 @@
font-size: to-rem($pxValue: 20);
padding-block: $db-spacing-m;

&::before {
&::after {
--icon-font-size: #{to-rem($pxValue: 32)};
}
}
Expand Down