Skip to content

refactor: enhanced clickable area on inline-end #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 16, 2024
Merged

refactor: enhanced clickable area on inline-end #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2d66dd5
refactor: enhanced clickable area on the inline-end
mfranzke May 23, 2024
6c62433
Merge branch 'main' into 838-radio-checkbox-non-interactive-white-spa…
mfranzke May 29, 2024
b9dba7b
Update _form-elements.scss
mfranzke May 29, 2024
6dc600e
Update _form-elements.scss
mfranzke May 29, 2024
47ab316
Merge branch 'main' into 838-radio-checkbox-non-interactive-white-spa…
mfranzke May 30, 2024
8452375
Merge branch 'main' into 838-radio-checkbox-non-interactive-white-spa…
mfranzke Jun 3, 2024
ed03df2
Update _form-elements.scss
mfranzke Jun 3, 2024
aa64c62
Merge branch 'main' into 838-radio-checkbox-non-interactive-white-spa…
mfranzke Jun 18, 2024
2904291
Merge branch 'main' into 838-radio-checkbox-non-interactive-white-spa…
nmerget Jul 16, 2024
8132995
refactor: prettier
mfranzke Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions source/_patterns/01-elements/_form-elements.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,18 @@
padding: to-rem($pxValue: 6) to-rem($pxValue: 10);
}
}

// enhance the clickable area for checkbox and radio elements
%form-element-enhanced-clickable-area {
&:has(+ label) {
&::after {
content: "";
width: calc(
var(--db-form-element-dimensions) + #{to-rem($pxValue: 4)}
);
height: var(--db-form-element-dimensions);
transform: translateX(#{to-rem($pxValue: 4)});
position: absolute;
}
}
}
13 changes: 10 additions & 3 deletions source/_patterns/01-elements/checkbox/checkbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@
@import "../form-elements";

.elm-checkbox {
--db-form-element-dimensions: var(
--db-checkbox-dimensions,
#{to-rem($pxValue: 24)}
);

@extend %form-element-enhanced-clickable-area;

@include icon("\00A0", 24, "outline", $partial: $partial);
align-content: center;

Expand All @@ -15,9 +22,9 @@
color: $checkbox---color;

display: inline-flex;
height: to-rem($pxValue: 24);
height: var(--db-form-element-dimensions);
justify-content: center;
width: to-rem($pxValue: 24);
width: var(--db-form-element-dimensions);

&[type="checkbox"] {
vertical-align: top;
Expand Down Expand Up @@ -67,6 +74,6 @@
& + label {
@extend %form-label;

margin-left: $db-spacing-xs;
padding-inline-start: $db-spacing-xs;
}
}
13 changes: 10 additions & 3 deletions source/_patterns/01-elements/radio/radio.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@
@import "../form-elements";

.elm-radio {
--db-form-element-dimensions: var(
--db-radio-dimensions,
#{to-em($pxValue: 20)}
);

@extend %form-element-enhanced-clickable-area;

appearance: none;

background-color: rgba(255, 255, 255, 0.1);
Expand All @@ -15,11 +22,11 @@
display: inline-block;

font-size: to-rem($pxValue: 16);
height: to-em($pxValue: 20);
height: var(--db-form-element-dimensions);

transition: border-width 0.5s ease;

width: to-em($pxValue: 20);
width: var(--db-form-element-dimensions);

&[type="radio"] {
vertical-align: sub;
Expand Down Expand Up @@ -56,7 +63,7 @@
& + label {
@extend %form-label;

margin-left: $db-spacing-xs;
padding-inline-start: $db-spacing-xs;
}

&:disabled {
Expand Down