Skip to content

refactor(progress): a11y optimizations #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 17, 2022
Merged

refactor(progress): a11y optimizations #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dabcbdc
refactor(progress): a11y optimizations
mfranzke Nov 11, 2022
9cb824d
refactor(progress): adapted HTML for the testcase
mfranzke Nov 11, 2022
330dba3
refactor(progress): adapted HTML for the testcase
mfranzke Nov 11, 2022
d1d5d5f
refactor(progress): adapted HTML for the testcase
mfranzke Nov 11, 2022
c5e69af
Merge branch 'main' into refactor-a11y-progress-element
mfranzke Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/cypress/integration/06-0-feedback/db-progress.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ context('db-progress', () => {
it('Progress should exist and be configurable', function () {
const simpleProgress = [0, 1];
simpleProgress.forEach((num) => {
cy.get('db-progress').eq(num).find('output').contains('60%');
cy.get('db-progress').eq(num).find('label').contains('60%');
cy.get('db-progress')
.eq(num)
.find('progress')
Expand All @@ -23,6 +23,6 @@ context('db-progress', () => {
.invoke('attr', 'indeterminate')
.should('exist');

cy.get('db-progress').eq(3).find('output').contains('60 ❤️');
cy.get('db-progress').eq(3).find('label').contains('60 ❤️');
});
});
2 changes: 1 addition & 1 deletion e2e/cypress/integration/99-1-showcases/showcases-other-elements.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ context('showcase', () => {
.should('eq', 'account');

// 2. DbProgress
cy.get('db-progress').eq(0).find('output').contains('60%');
cy.get('db-progress').eq(0).find('label').contains('60%');
cy.get('db-progress')
.eq(0)
.find('progress')
Expand Down
6 changes: 4 additions & 2 deletions packages/db-ui-elements-stencil/src/components/db-progress/__tests__/db-progress.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ describe('db-progress', () => {
expect(page.root).toEqualHtml(`
<db-progress htmlid="progress-label-01">
<div class="elm-progress">
<progress id="progress-label-01"></progress>
<output htmlFor="progress-label-01">%</output>
<progress aria-describedby="progress-label-01-label" id="progress-label-01"></progress>
<label aria-hidden="true" htmlfor="progress-label-01" id="progress-label-01-label">
%
</label>
</div>
</db-progress>
`);
Expand Down
9 changes: 7 additions & 2 deletions packages/db-ui-elements-stencil/src/components/db-progress/db-progress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,17 @@ export class DbProgress {
? { ['--progress-conic']: `${this.value}` }
: { ['']: '' }
}
aria-describedby={this.htmlid + '-label'}
/>
{!this.indeterminate && (
<output htmlFor={this.htmlid}>
<label
htmlFor={this.htmlid}
id={this.htmlid + '-label'}
aria-hidden="true"
>
{this.value}
{this.percentagesign}
</output>
</label>
)}
</div>
);
Expand Down