Skip to content

feat(accordion): added new name attribute #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2023
Merged

feat(accordion): added new name attribute #1642

merged 3 commits into from
Nov 29, 2023

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Oct 4, 2023

Proposed changes

Resolves https://github.com/db-ui/mono/issues/1630

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Oct 4, 2023
@mfranzke mfranzke self-assigned this Oct 4, 2023
@mfranzke mfranzke linked an issue Oct 4, 2023 that may be closed by this pull request
Accordion: Adapt native standard #1630
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/1630-accordion-adapt-native-standard

@nmerget nmerget added 🍄🆙improvement New feature or request and removed improvement labels Nov 17, 2023
@nmerget nmerget marked this pull request as ready for review November 29, 2023 14:10
@nmerget nmerget enabled auto-merge (squash) November 29, 2023 14:10
@nmerget nmerget merged commit bfd0296 into main Nov 29, 2023
@nmerget nmerget deleted the 1630-accordion-adapt-native-standard branch November 29, 2023 15:22
@mfranzke mfranzke restored the 1630-accordion-adapt-native-standard branch November 29, 2023 22:10
@mfranzke mfranzke deleted the 1630-accordion-adapt-native-standard branch November 29, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch

Assignees

@mfranzke mfranzke

Labels

🍄🆙improvement New feature or request

Projects

None yet

Milestone

Open Beta Release (0.1.0)

Development

Successfully merging this pull request may close these issues.

Accordion: Adapt native standard

3 participants

@mfranzke @nmerget