Skip to content

refactor: changed react components to use proper typescript types #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 29, 2023
Merged

refactor: changed react components to use proper typescript types #1865

merged 14 commits into from
Nov 29, 2023

Conversation

@nmerget
Copy link
Collaborator

@nmerget nmerget commented Nov 17, 2023

Proposed changes

  • add typescript types for components to use them in react
  • e.g. enables DBInput to use aria-xxx or onMouseEnter directly

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-react-types-components

@github-actions github-actions bot added 🧱components Changes inside components folder 📺showcases Changes to 1-n showcases labels Nov 17, 2023
@nmerget nmerget linked an issue Nov 17, 2023 that may be closed by this pull request
db-checkbox: checked property leads to disabled checkbox #1646
Closed
7 tasks
This was linked to issues Nov 28, 2023
Check TypeScript support #1906
Closed
Check props support #1907
Closed
mfranzke
mfranzke reviewed Nov 28, 2023
View reviewed changes
mfranzke
mfranzke reviewed Nov 29, 2023
View reviewed changes
mfranzke
mfranzke reviewed Nov 29, 2023
View reviewed changes
mfranzke
mfranzke reviewed Nov 29, 2023
View reviewed changes
@nmerget nmerget enabled auto-merge (squash) November 29, 2023 10:05
mfranzke
mfranzke previously approved these changes Nov 29, 2023
View reviewed changes
@nmerget nmerget requested a review from mfranzke November 29, 2023 11:05
@nmerget nmerget merged commit d7ea621 into main Nov 29, 2023
@nmerget nmerget deleted the refactor-react-types-components branch November 29, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch

Assignees

No one assigned

Labels

🧱components Changes inside components folder 📺showcases Changes to 1-n showcases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check props support Check TypeScript support db-checkbox: checked property leads to disabled checkbox

3 participants

@nmerget @mfranzke