Skip to content

feat(components): ensure that the assets are packaged as well #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2024
Merged

feat(components): ensure that the assets are packaged as well #2135

merged 2 commits into from
Jan 26, 2024

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Jan 25, 2024

Proposed changes

Resolves https://github.com/db-ui/mono/issues/2134

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jan 25, 2024
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Jan 25, 2024
@mfranzke mfranzke self-assigned this Jan 25, 2024
@mfranzke mfranzke linked an issue Jan 25, 2024 that may be closed by this pull request
refactor(components): assets are missing #2134
Closed
7 tasks
@mfranzke mfranzke marked this pull request as ready for review January 25, 2024 18:40
@mfranzke mfranzke enabled auto-merge January 25, 2024 18:40
@github-actions github-actions bot added the 🧱components Changes inside components folder label Jan 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/2134-refactorcomponents-assets-are-missing

@mfranzke mfranzke merged commit d23c4e3 into main Jan 26, 2024
@mfranzke mfranzke deleted the 2134-refactorcomponents-assets-are-missing branch January 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget Awaiting requested review from nmerget

@annsch annsch Awaiting requested review from annsch

1 more reviewer

@dkolba dkolba dkolba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mfranzke mfranzke

Labels

🧱components Changes inside components folder 🍄🆙improvement New feature or request

Projects

None yet

Milestone

Open Beta Release (0.1.0)

Development

Successfully merging this pull request may close these issues.

refactor(components): assets are missing

3 participants

@mfranzke @dkolba