Skip to content

fix(select): set placeholder option as selected if it doesn't have a value #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 2, 2025
Merged

fix(select): set placeholder option as selected if it doesn't have a value #4885

merged 6 commits into from
Sep 2, 2025

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Sep 2, 2025

Proposed changes

Angular is currently blocking the main branch pipeline as it‘s reporting a non-selected first option within the select component if a placeholder is beinh used.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d504dcb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-select-placeholder-selected-angular

@mfranzke mfranzke self-assigned this Sep 2, 2025
@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Sep 2, 2025
@mfranzke mfranzke changed the title fix(select): Set placeholder option as selected when no value fix(select): set placeholder option as selected when no value Sep 2, 2025
@mfranzke mfranzke changed the title fix(select): set placeholder option as selected when no value fix(select): set placeholder option as selected if it doesn't contain a value Sep 2, 2025
mfranzke and others added 3 commits September 2, 2025 14:37
@mfranzke
Merge branch 'main' into fix-select-placeholder-selected-angular
78094a8
@github-actions
auto update snapshots (#4892)
9da16ea 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke
Create cyan-scissors-burn.md
5033a3e
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Sep 2, 2025
mfranzke and others added 2 commits September 2, 2025 17:40
@mfranzke
Merge branch 'main' into fix-select-placeholder-selected-angular
42db84b
@github-actions
auto update snapshots (#4900)
d504dcb 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke changed the title fix(select): set placeholder option as selected if it doesn't contain a value fix(select): set placeholder option as selected if it doesn't have a value Sep 2, 2025
@mfranzke mfranzke merged commit ab4cd2e into main Sep 2, 2025
54 checks passed
@mfranzke mfranzke deleted the fix-select-placeholder-selected-angular branch September 2, 2025 16:44
@github-project-automation github-project-automation bot moved this from 🏗 In development to ✅ Done in UX Engineering Team Backlog Sep 2, 2025
mfranzke added a commit that referenced this pull request Sep 2, 2025
@mfranzke
Revert "fix(select): set placeholder option as selected if it doesn't…
2b9de3f 
… have a value (#4885)"

This reverts commit ab4cd2e.
mfranzke added a commit that referenced this pull request Sep 2, 2025
@mfranzke
fix(select): Angular tests (#4903)
683861f 
* Revert "fix(select): set placeholder option as selected if it doesn't have a value (#4885)"

This reverts commit ab4cd2e.

* test: let's give this a try
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget Awaiting requested review from nmerget

@michaelmkraus michaelmkraus Awaiting requested review from michaelmkraus

Assignees

@mfranzke mfranzke

Labels

🏘components 📕documentation Improvements or additions to documentation

Projects

UX Engineering Team Backlog
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mfranzke