Added way to retrieve existing jobs per tags.#419
Merged
SijmenHuizenga merged 4 commits intodbader:masterfrom Jan 31, 2021
Skenvy:master
Merged
Added way to retrieve existing jobs per tags.#419SijmenHuizenga merged 4 commits intodbader:masterfrom Skenvy:master
SijmenHuizenga merged 4 commits intodbader:masterfrom
Skenvy:master
Conversation
Collaborator
|
Hi! Thanks for this pr. Good idea to add this! Would you be able to add some tests and an example in the docs? Let me know if you need help with any of that. |
Contributor
Author
|
Added/fixed the test I added for this. Let me know if you need anything else for this PR |
Contributor
Author
|
Squashed the changes into 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In making extensive use of multiple
tagson eachJob(that define multiple configuration settings that define what that job does, as well as manufactured guids) I've encountered the following need/nice-to-have.If I have functionality that finds
Job's that can be periodically removed by comparing against a table of changing guids, but I've used thetagsto hold the relevant information that I would like tologto have a human readable history of whatJob's were removed, I need a way to getJob's bytags.The alternative would be to have the
Scheduler.clear(...)return the list of jobs that it had removed.