Skip to content

feat: Added support for MorphIO options and fixed single point branches in NEURON builder#210

Merged
drodarie merged 9 commits intomainfrom
feature/arborize/single-points
Jan 13, 2026
Merged

feat: Added support for MorphIO options and fixed single point branches in NEURON builder#210
drodarie merged 9 commits intomainfrom
feature/arborize/single-points

Conversation

@Helveg
Copy link
Contributor

@Helveg Helveg commented Jan 7, 2026

fixes #205

Tasks

  • Added tests
  • Updated documentation

📚 Documentation preview 📚: https://nrn-patch--210.org.readthedocs.build/en/210/


📚 Documentation preview 📚: https://arborize--210.org.readthedocs.build/en/210/

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 97.61905% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.78%. Comparing base (715b59e) to head (a5f868e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
libs/arborize/arborize/builders/_neuron.py 97.36% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   78.58%   77.78%   -0.81%     
==========================================
  Files         196       23     -173     
  Lines       18085     2021   -16064     
  Branches     2125      252    -1873     
==========================================
- Hits        14213     1572   -12641     
+ Misses       3317      381    -2936     
+ Partials      555       68     -487     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Helveg Helveg changed the title Added support for MorphIO options and fixed single point branches in NEURON builder feat: Added support for MorphIO options and fixed single point branches in NEURON builder Jan 8, 2026
@github-actions github-actions bot added the feat label Jan 8, 2026
@Helveg
Copy link
Contributor Author

Helveg commented Jan 8, 2026

@danielelinaro Please have a look whether the new neuron_build builds the granule cell morphology without single point sections :)

@danielelinaro
Copy link

@Helveg everything seems to be working fine, thanks for the fix!

@Helveg Helveg requested review from drodarie and filimarc January 10, 2026 17:53
Copy link
Contributor

@filimarc filimarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drodarie drodarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe test the small snippet of code not covered by unittests.

@drodarie drodarie merged commit 3a28863 into main Jan 13, 2026
26 checks passed
@drodarie drodarie deleted the feature/arborize/single-points branch January 13, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NEURON extracellular mechanism changes cell dynamics

4 participants