Create source distributions on macOS during build#384
Conversation
|
Please make sure the checks pass 😄 |
| if sys.platform == 'darwin': | ||
| utility.exec_command('%s setup.py check -r -s sdist --formats=gztar,zip' % PYTHON, | ||
| utility.ROOT_DIR, continue_on_error=False) | ||
|
|
There was a problem hiding this comment.
please test the entire product E2E with these changes
There was a problem hiding this comment.
maybe by uploading to pypi test 😄
| continue_on_error=False) | ||
|
|
||
| # generate sdist--only run on Mac to eliminate redundant copies when published to Azure | ||
| if sys.platform == 'darwin': |
There was a problem hiding this comment.
please document that mac wasn't chosen for a reason (you just needed to choose one platform) to avoid future confusion
ellbosch
force-pushed
the
ellbosch/sdist
branch
from
77c96d3 to
5315975
Compare
|
@chlafreniere: a few changes made since our meeting yesterday:
|
release.py
Outdated
| # Only authorized users with credentials will be able to upload this package. | ||
| # Credentials will be stored in a .pypirc file. | ||
| for wheel in mssqlcli_wheel_dir: | ||
| for f in mssqlcli_dist_dir: |
There was a problem hiding this comment.
Stands for file. I wanted to disambiguate this from wheels since we have an sdist now.
There was a problem hiding this comment.
Could we use "file" here instead, to avoid ambiguity?
There was a problem hiding this comment.
No, unfortunately, since file is a builtin. I'm open to a better name here--maybe file_dist?
corivera
left a comment
corivera
left a comment
There was a problem hiding this comment.
Approved pending other comments.
3 participants
Closes #322.
This PR adds support for creating gztar and zip source distributions. The
sdistcall is made during the build phase, which is also when wheel files are created.Furthermore, I added a check to only call
sdistif the platform is macOS. This is because unlike wheel files, it is not required to generate source distributions on every platform we wish to support*, since we can generate both the gztar and zip from macOS.*I need to test this hypothesis :)