Skip to content

Added support for Linux package codesigning#435

Merged
ellbosch merged 8 commits intomasterfrom
ellbosch/linux-publish
Mar 16, 2020
Merged

Added support for Linux package codesigning#435
ellbosch merged 8 commits intomasterfrom
ellbosch/linux-publish

Conversation

@ellbosch
Copy link
Copy Markdown
Collaborator

@ellbosch ellbosch commented Mar 6, 2020

Note: these changes have already been validated with Azure DevOps with successful runs.

This PR updates our Dockerfile scripts for debian and rpm packaging in the following ways:

  • Adds support for codesigning. Dockerfiles have new commands to copy deb and rpm packages to the root of the container, which enables Docker to copy packages from the container to the host. With packages now in the host, we can run the ESRP DevOps codesign task.
  • Removes Python dependency installation in Dockerfile. DevOps pipelines have been updated to publish packages directly from the host, rather than from Docker. With this change, there's no longer a dependency on our Python code to publish deb and rpm packages to daily storage.
  • Updated docs. Release docs have now been updated to reflect the aforementioned changes to publishing. I've also added the sh suffix to codeblocks for formatting.

@ellbosch ellbosch force-pushed the ellbosch/linux-publish branch from eac6c9f to e81e37f Compare March 7, 2020 04:54
Comment thread build.py
RUN mkdir Repos/mssql-cli
ADD . Repos/mssql-cli
WORKDIR Repos/mssql-cli
RUN mkdir /Repos
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're hardcoding and assuming a /Repos/mssql-cli? Seems fine for docker, but we can't make this assumption for dev boxes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure, I've accounted for this.

@ellbosch ellbosch requested a review from pensivebrian March 7, 2020 19:07
@ellbosch ellbosch merged commit 78351e3 into master Mar 16, 2020
@ellbosch ellbosch deleted the ellbosch/linux-publish branch March 16, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants