fix cred scan issue #530
Merged
fix cred scan issue #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llali
approved these changes
Sep 16, 2021
| set http_proxy=domain\username:password@proxy_server:port | ||
| set https_proxy=domain\username:password@proxy_server:port | ||
| ``` | ||
| If the Password contains special characters like `@,$,!` (e.g. `password:p@ssword`) then replace the special characters by their hex code equivalents with `%` prefix, as exemplified below: |
There was a problem hiding this comment.
this won't make the test fail? the password won't be complex enough
Contributor
Author
There was a problem hiding this comment.
the credscan log says that it failed in doc\installation\windows.md(42,)
udeeshagautam
approved these changes
Sep 16, 2021
Contributor
Author
|
merging this pr, since it's just a update in documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.