Autocompletion for replication commands is lacking

[datacharmer]

I see that almost everything related to replication is missing in the autocompletion:

CHANGE MASTER TO (MariaDB 10.x )
SHOW ALL SLAVES STATUS (MariaDB 10.x)
SHOW SLAVE connection_name STATUS (MariaDB 10.x)
START/STOP [connection_name] SLAVE

CHANGE MASTER TO (MySQL 5.7)
SHOW SLAVE STATUS [FOR CHANNEL connection_name] (MySQL 5.7)
START/STOP SLAVE [for channel ...]
CHANGE REPLICATION FILTER

[amjith]

You're right it is lacking. That is one area I need to improve. I'll add a new completion category and see if I can make this work. Thanks for the links to docs. :)

[amjith]

@datacharmer I've implemented the completions for replication related statements. Please let me know if anything is still missing.

The changes are available in master and you can try it out by installing directly from master as follows:

pip install -U https://github.com/dbcli/mycli/archive/master.zip

[datacharmer]

I see that the at least the following statements are not in the autocompletion:

# mysql 5.7
CHANGE MASTER TO  MASTER_AUTO_POSITION=1 for channel 'xxx'
START/STOP SLAVE FOR CHANNEL 'xxx'

# mariadb 10.x  
CHANGE MASTER 'yyy' TO MASTER_USE_GTID=current_pos
START/STOP slave 'yyy'
SHOW ALL SLAVES STATUS

[amjith]

Looks like I shouldn't blindly copy the terms in for the suggestion candidates. I hadn't anticipated the difference between MariaDB and MySQL. I might run a help command and try to parse the output to populate the possible candidates. Thank you for testing it and providing quick feedback. I'll work on it more and get back to you.

[rolandwalker]

It looks like @amjith made some improvements in this issue back in 2015, and we just improved completions further in #1447. I'm not sure we should prioritize going deeper into the different MySQL versions, when there are other places in the completions which need more work (for statements entered more frequently than replication commands).

Therefore I'm closing, though anyone should feel free to re-open.