CB-2797: TE. Support deleting connection folders#1256
Merged
alexander-skoblikov merged 1 commit intodevelfrom Nov 10, 2022
Merged
CB-2797: TE. Support deleting connection folders#1256alexander-skoblikov merged 1 commit intodevelfrom
alexander-skoblikov merged 1 commit intodevelfrom
Conversation
oksana-cherniavskaia
requested review from
alexander-skoblikov,
serge-rider and
yagudin10
oksana-cherniavskaia
force-pushed
the
CB-2674-te-connection-folder-delete
branch
2 times, most recently
from
fddaafb to
e7b6d2c
Compare
| @NotNull String[] folderPaths, | ||
| boolean dropContents | ||
| ) throws DBException { | ||
| final DBPProject project = getProjectMetadata(projectId); |
Collaborator
There was a problem hiding this comment.
we don't use final according to our code style
Contributor
Author
There was a problem hiding this comment.
((that is unfortunate , btw )
oksana-cherniavskaia
force-pushed
the
CB-2674-te-connection-folder-delete
branch
from
e7b6d2c to
cac0e16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.