CB-2867 support dataset in UI#1436
Merged
alexander-skoblikov merged 33 commits intodevelfrom Feb 8, 2023
Merged
Conversation
alexander-skoblikov
changed the title
…eaver/cloudbeaver into CB-2867-support-dataset-in-ui
devnaumov
approved these changes
Feb 7, 2023
| onValuePresentationChange, | ||
| }, ['setPresentation', 'setValuePresentation', 'switchValuePresentation', 'closeValuePresentation']); | ||
|
|
||
| const needRefresh = getComputed(() => ( |
Member
There was a problem hiding this comment.
Please cast dataModel to a boolean !!dataModel so needRefresh will return boolean, not boolean | undefined
|
|
||
| const nodes = navNodeInfoResource | ||
| .get(resourceKeyList(children)) | ||
| .filter<NavNode>((node => node !== undefined) as (node: NavNode | undefined) => node is NavNode) |
Member
There was a problem hiding this comment.
Maybe use utility function filterUndefined?
| const scriptName = `${result.name.trim()}.${SCRIPT_EXTENSION}`; | ||
| const resourceType = this.projectInfoResource.getResourceType(project, SCRIPTS_TYPE_ID); | ||
| if (!resourceType) { | ||
| throw new Error('Resource type not found'); |
Member
There was a problem hiding this comment.
Please include resource type in error message
| const isActiveSegmentMode = getComputed(() => data.activeSegmentMode.activeSegmentMode); | ||
| const displayedEditors = getComputed(() => sqlEditorModeService.tabsContainer.getDisplayed({ state, data }).length); | ||
|
|
||
| useEffect(() => { |
Member
There was a problem hiding this comment.
Maybe better to move splitting logic to the separate hook
| await this.executeQueryAction( | ||
| query, | ||
| async () => { | ||
| if ((this.dataSource?.databaseModels.length ?? 0) > 0) { |
Member
There was a problem hiding this comment.
just !!this.dataSource?.databaseModels.length
| const databaseModels = dataSource?.databaseModels; | ||
|
|
||
| if (!databaseModels) { | ||
| console.error('databaseModels executionContext is not provided'); |
Member
There was a problem hiding this comment.
Maybe better to throw an error as we return from function in this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.