CB-3235-Send-event-about-session-expire#1576
Merged
alexander-skoblikov merged 13 commits intoCB-2773-TE-event-pulling-send-session-status-as-an-eventfrom Apr 7, 2023
Merged
Conversation
EmYar
changed the base branch from
devel
to
CB-2773-TE-event-pulling-send-session-status-as-an-event
| var sessionExpiredEvent = new WSSessionExpiredEvent(); | ||
| for (CBWebSessionEventHandler sessionEventHandler : sessionEventHandlers) { | ||
| try { | ||
| sessionEventHandler.handeWebSessionEvent(sessionExpiredEvent); |
Collaborator
There was a problem hiding this comment.
Why we cant use addSessionEvent here?
Contributor
Author
There was a problem hiding this comment.
Because it is a system event.
It shouldn't be filtered. We want to send it right before the session is closed, within one lock. It is also not required to write an error to the session log, because it is planned to be closed - if there is a problem, it will be written to the general application log
# Conflicts: # server/bundles/io.cloudbeaver.server/schema/service.events.graphqls
Fixes WSSessionExpiredEvent description in comment
Moves WSSocketConnectedEvent to session package
Implements BaseWebSession#sendSystemEvent
Implements a WSSessionStateEvent and a job to send it periodically
Fixes code style issues
…t' into CB-3235-Send-event-about-session-expire
…bout-session-expire
alexander-skoblikov
merged commit 7b97089
into
CB-2773-TE-event-pulling-send-session-status-as-an-event
alexander-skoblikov
added a commit
that referenced
this pull request
Apr 19, 2023
* CB-3235-Send-event-about-session-expire (#1576) * CB-3235 Send event about session expire * CB-3235 Send event about session expire Fixes WSSessionExpiredEvent description in comment * CB-3235 Send event about session expire Moves WSSocketConnectedEvent to session package * CB-3235 Send event about session expire Implements BaseWebSession#sendSystemEvent * CB-3235 Send event about session expire Implements a WSSessionStateEvent and a job to send it periodically * CB-3235 Send event about session expire Fixes code style issues * CB-2997 jetty server bundle (#1587) * CB-2997 jetty server bundle * CB-2997 remove jetty dependencies * CB-3235 review fixes --------- Co-authored-by: Ainur <59531286+yagudin10@users.noreply.github.com> Co-authored-by: Aleksandr Skoblikov <aleksandr.skoblikov@dbeaver.com> * CB-2773 handle session expire and session state events * CB-2773 fix * CB-2773 subscribe to topic, handle session state event --------- Co-authored-by: Yaroslav Emelyanov <iaroslav.emelianov@dbeaver.com> Co-authored-by: Ainur <59531286+yagudin10@users.noreply.github.com> Co-authored-by: Tatiana Fokina <tatiana.fokina@dbeaver.com> Co-authored-by: dariamarutkina <125263541+dariamarutkina@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.