feature(core-blocks): CB-209 added custom checkboxes#172
Merged
Conversation
Wroud
requested changes
Oct 7, 2020
Wroud
requested changes
Oct 7, 2020
Member
|
There now wrong abstraction, you duplicating checkbox logic in FIeldCheckbox and Checkbox, you should unit CheckboxMarkup with Checkbox and remove duplicating logic from FieldCheckbox and use Checkbox in it, so the main logic was in Checkbox, FieldCheckbox must be just wrapper over Checkbox |
Wroud
requested changes
Oct 8, 2020
Wroud
requested changes
Oct 8, 2020
Wroud
requested changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.