Skip to content

fix(plugin-data-spreadsheet): CB-418 copy cell by Cmd+C lowerCase fix #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wroud merged 3 commits into from
Oct 13, 2020
Merged

fix(plugin-data-spreadsheet): CB-418 copy cell by Cmd+C lowerCase fix #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08cceb7
fix(plugin-data-spreadsheet): CB-418 copy cell by Cmd+C lowerCase fix
devnaumov Oct 13, 2020
427b66b
fix(plugin-data-spreadsheet): CB-418 copy cell by Cmd+C lowerCase
devnaumov Oct 13, 2020
4ce12c7
fix(plugin-data-spreadsheet): CB-418 copy cell by Cmd+C lowerCase
devnaumov Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webapp/packages/plugin-data-export/src/locales/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export default [
['data_transfer_dialog_configuration_title', 'Export configuration'],
['data_transfer_dialog_preparation', 'We prepare your file for export. Please wait...'],
['data_transfer_notification_preparation', 'We prepare your file for download. Please wait...'],
['data_transfer_notification_ready', 'File ready to download'],
['data_transfer_notification_ready', 'File is ready to download'],
['data_transfer_notification_error', 'Preparation failed or canceled'],
['data_transfer_notification_download', 'Download'],
['data_transfer_notification_delete', 'Delete'],
Expand Down
4 changes: 2 additions & 2 deletions ...ackages/plugin-data-spreadsheet/src/AgGridTable/modules/RangeSelection/rangeController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ interface CellKeyDownEvent extends AgGridEvent{
}

const EVENT_KEY_CODE = {
C: 'C',
C: 'KeyC',
};

interface TemporarySelectionRange {
Expand Down Expand Up @@ -103,7 +103,7 @@ export class RangeController implements IRangeController {
}

private handleDocumentCopy(event: KeyboardEvent) {
if (event.key === EVENT_KEY_CODE.C && (event.ctrlKey || event.metaKey)) {
if (event.code === EVENT_KEY_CODE.C && (event.ctrlKey || event.metaKey)) {
this.copySelectedData();
}
}
Expand Down