Skip to content

CB-4281 send saveCredentials flag only if credentials exist#2154

Merged
serge-rider merged 4 commits intodevelfrom
CB-4281-te-editor-viewer-cached-unsaved-ssh-credentials-cant-initialize-tunnel-error
Nov 28, 2023
Merged

CB-4281 send saveCredentials flag only if credentials exist#2154
serge-rider merged 4 commits intodevelfrom
CB-4281-te-editor-viewer-cached-unsaved-ssh-credentials-cant-initialize-tunnel-error

Conversation

@devnaumov
Copy link
Copy Markdown
Member

No description provided.

@devnaumov devnaumov requested a review from Wroud November 21, 2023 18:43
@devnaumov devnaumov self-assigned this Nov 21, 2023
@Wroud
Copy link
Copy Markdown
Member

Wroud commented Nov 22, 2023

probably we want to migrate DBAuthDialogController to hooks and use:

  let authModelId: string | null = null;

  if (connection.connectionInfo?.authNeeded || payload.resetCredentials) {
    authModelId = connection.connectionInfo?.authModel || driver?.defaultAuthModel || null;
  }

authModelId to determine when we requested user to enter database credentials and send config.credentials and config.saveCredentials only in this case

@serge-rider serge-rider merged commit e8bf1ba into devel Nov 28, 2023
@serge-rider serge-rider deleted the CB-4281-te-editor-viewer-cached-unsaved-ssh-credentials-cant-initialize-tunnel-error branch December 1, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants