Conversation
sergeyteleshev
approved these changes
Dec 8, 2023
| import { useStyles } from './useStyles'; | ||
|
|
||
| interface Props { | ||
| tag?: 'button' | 'a' | 'div'; |
Contributor
There was a problem hiding this comment.
Why do we need this? I believe it is better to divide functionality. For example if we want a button to behave like a link it should be something like this:
<Link>
<Button>Button Text></Button>
</Link>
Member
Author
There was a problem hiding this comment.
according to HTML, it's a really bad idea to place tags like this: <a><button></button></a>
the main idea here is that sometimes we want to display button looking component as a link or div so we can place it in another component like a button or input label
(it's really rare cases usually)
|
|
||
| this.onFormat.execute([script, formatted]); | ||
| this.setQuery(query.substring(0, script.begin) + formatted + query.substring(script.end)); | ||
| this.setScript(query.substring(0, script.begin) + formatted + query.substring(script.end)); |
Contributor
There was a problem hiding this comment.
Sometimes JS behaves crazy in this cases of concatenation if data is not as it expected to be. I would recommend to use .concat method to avoid bugs in future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.