CB-4468 iterate over copy of state array

[devnaumov]

No description provided.

[sergeyteleshev]

I suggest to do the same thing for this function below. Just to avoid similar bug in future when the logic gets a bit more complex:

async canCloseResultTabs(state: ISqlEditorTabState): Promise<boolean> {
    const tabs = state.tabs.slice();
    for (const tab of tabs) {
      const canClose = await this.sqlQueryResultService.canCloseResultTab(state, tab.id);

      if (!canClose) {
        return false;
      }
    }

    return true;
  }

[Wroud]

This one is a bit tricky because of asynchronous.
Imagine a case when we clicked to close all tabs

1. First, we will check that every tab can be closed
2. for example, let's assume that one tab can close fn took more than a 1s
3. we can try to close any other tab at this moment

This will create a case when a tab in the tabs array is closed.

So, in general, canCloseResultTabs is not affected by this bug, but I described another case before. So, we probably need to track such operations and disable related actions during transactions.

[Wroud]

This one is a bit tricky because of asynchronous.
Imagine a case when we clicked to close all tabs

1. First, we will check that every tab can be closed
2. for example, let's assume that one tab can close fn took more than a 1s
3. we can try to close any other tab at this moment

This will create a case when a tab in the tabs array is closed.

So, in general, canCloseResultTabs is not affected by this bug, but I described another case before. So, we probably need to track such operations and disable related actions during transactions.