Merged
Conversation
sergeyteleshev
approved these changes
Feb 22, 2024
| let presented = true; | ||
|
|
||
| if (isNotNullDefined(value) && isObject(value)) { | ||
| presented = isControlPresented(String(name), value, defaultValue); |
Contributor
There was a problem hiding this comment.
You pass also a symbol type here converted to string. so it transforms to something like on the screen. Which is probably won't be a part of an object at all
Should we add one more type Symbol to isControlPresented first argument?
And add here one more case where you can pass symbol time without converting it to the string
devnaumov
approved these changes
Feb 22, 2024
sergeyteleshev
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.