CB-4686 add new client event for updating session info#2462
Merged
alexander-skoblikov merged 27 commits intodevelfrom Mar 27, 2024
Merged
Conversation
…n-api-call-to-a-websocket-event
…n-api-call-to-a-websocket-event
…n-api-call-to-a-websocket-event
| @@ -135,6 +137,26 @@ export class SessionEventSource implements IServerEventEmitter<ISessionEvent, IS | |||
|
|
|||
| disconnect() { | |||
Contributor
There was a problem hiding this comment.
https://rxjs.dev/api/webSocket/webSocket - the rxjs websocket is tried to reconnect cause there was some subscriptions
Wroud
requested changes
Mar 19, 2024
…event arrived" This reverts commit 7aeffff.
…n-api-call-to-a-websocket-event
devnaumov
reviewed
Mar 19, 2024
|
|
||
| const sessionState: SessionState = { | ||
| ...this.data, | ||
| valid: event?.isValid ?? this.data?.valid, |
Member
There was a problem hiding this comment.
seems like this.data is defined here
Wroud
requested changes
Mar 19, 2024
Wroud
reviewed
Mar 19, 2024
…n-api-call-to-a-websocket-event
…n-api-call-to-a-websocket-event
…n-api-call-to-a-websocket-event
Wroud
approved these changes
Mar 21, 2024
…n-api-call-to-a-websocket-event
…n-api-call-to-a-websocket-event
…n-api-call-to-a-websocket-event
…n-api-call-to-a-websocket-event
yagudin10
deleted the
CB-4686-migrate-from-scheduled-touch-session-api-call-to-a-websocket-event
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.