CB-4707 move connection shield logic to separate component#2478
Merged
Conversation
sergeyteleshev
approved these changes
Mar 19, 2024
|
|
||
| const connection = useResource(ConnectionShield, ConnectionInfoResource, connectionKey); | ||
|
|
||
| const [connecting, setConnecting] = useState(false); |
Contributor
There was a problem hiding this comment.
I suggest to move this flag to ConnectionsManagerService and make it observable. from this point connecting state will be available not only here but wherever it is needed in future
| } | ||
| } | ||
|
|
||
| if (connection.data && !connection.data.connected) { |
Contributor
There was a problem hiding this comment.
I dont like we have drawing logic here and in the parent component. Lets make it in one place here
we can add extra prop something like noDataPlaceholderText
and if there is no connectcion.data we draw placeholder here.
if noDataPlaceholderText is not provided, draw a default defined placeholder
after that you can safely remove this code from the parent component:
<TextPlaceholder>{translate('plugin_object_viewer_table_no_items')}</TextPlaceholder>
Wroud
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.