Conversation
Wroud
reviewed
Apr 10, 2024
Comment on lines
+37
to
+39
| <div className={s(styles, { notification: true, mounted, closing }, className)}> | ||
| <div ref={focusedRef} className={s(styles, { notification: true, mounted, closing }, className)}> |
Member
There was a problem hiding this comment.
I'm not sure that we want to steal focus right when a notification appears. The original issue is that's impossible to navigate to snackbar with TAB, maybe we just need to add a proper tabIndex?
Wroud
approved these changes
Apr 12, 2024
sergeyteleshev
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.