Cb 4629 end user preferences#2546
Conversation
| <ToolsAction icon="admin-cancel" viewBox="0 0 24 24" disabled={!changed} onClick={handleReset}> | ||
| {translate('ui_processing_cancel')} | ||
| </ToolsAction> | ||
| <ToolsAction icon="admin-cancel" viewBox="0 0 24 24" onClick={handleRestoreDefaults}> |
There was a problem hiding this comment.
I dont like we have 2 similar icons. This is misleading the user
| } | ||
|
|
||
| function handleRestoreDefaults() { | ||
| userSettingsService.restoreDefaults(); |
There was a problem hiding this comment.
Usually restore settings goes this scenario:
- press restore settings
- popup "are you sure you want to restore settings"
- click yes/no
- settings applies
Since we have another pipline here, which is fine, by the way. I believe we should add here some kind of notification here that we pasted here default settings but did not save it yet.
Cuase for example: user had first 5 setttings as default. All settings below visible window area were different from default. You clicked this button and user did not see that something were changed. We need to cover this case so user would not have been missleaded. Generally we need to notify somehow that we pasted something successfully
Or we can go always go first scenario
| getHandler(contexts: IDataContextProvider): IMenuHandler | null { | ||
| const menu = contexts.getOwn(DATA_CONTEXT_MENU); | ||
|
|
||
| handlers: for (const handler of this.handlers.values()) { |
There was a problem hiding this comment.
seems like this logic duplicates in handlig actions and bindings. I beleive we can unify it in function with this cycle. but may be it is not a bad idea to leave it as it is for flexibility reasons
Wroud
force-pushed
the
CB-4629-end-user-preferences
branch
from
ea9e39c to
d28715c
Compare
6 participants
No description provided.