Skip to content

feat(core-connections): CB-692 add new custom properties#281

Merged
Wroud merged 2 commits intodevelfrom
feat/new-custom-properties
Feb 4, 2021
Merged

feat(core-connections): CB-692 add new custom properties#281
Wroud merged 2 commits intodevelfrom
feat/new-custom-properties

Conversation

@devnaumov
Copy link
Copy Markdown
Member

No description provided.

@devnaumov devnaumov requested a review from Wroud February 4, 2021 15:02
@devnaumov devnaumov self-assigned this Feb 4, 2021
export type CheckboxBaseProps = Omit<React.InputHTMLAttributes<HTMLInputElement>, 'onChange' | 'type' | 'value' | 'checked'> & {
value?: string;
checkboxLabel?: string;
title?: string;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it's not needed here

id={value || name}
checked={checked}
label={checkboxLabel}
title={title}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

value,
state,
checkboxLabel,
title,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@Wroud Wroud merged commit 801bf30 into devel Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants