Skip to content

CB-5393 fix: modal submenu#2830

Merged
Wroud merged 2 commits intodevelfrom
fix/cb-5393/modal-sub-menu
Aug 7, 2024
Merged

CB-5393 fix: modal submenu#2830
Wroud merged 2 commits intodevelfrom
fix/cb-5393/modal-sub-menu

Conversation

@Wroud
Copy link
Copy Markdown
Member

@Wroud Wroud commented Aug 6, 2024

No description provided.

@Wroud Wroud requested a review from devnaumov August 6, 2024 13:59
@Wroud Wroud self-assigned this Aug 6, 2024
@Wroud Wroud requested a review from sergeyteleshev August 6, 2024 13:59

return (
<ContextMenu menu={subMenuData} className={className} rtl={rtl} disclosure {...nestedMenuSettings}>
<ContextMenu menu={subMenuData} className={className} rtl={rtl} modal disclosure {...nestedMenuSettings}>
Copy link
Copy Markdown
Contributor

@sergeyteleshev sergeyteleshev Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it affects a lot of other menus. not only auto-refresh one. does nestedMenuSettings.modal = true works for this case? may be better like this if it does so no side effects

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can make it the default behavior for simplicity

@Wroud Wroud merged commit afb4ea2 into devel Aug 7, 2024
@Wroud Wroud deleted the fix/cb-5393/modal-sub-menu branch August 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants