Skip to content

fix(plugin-data-spreadsheet-new): CB-757 add getColumnsWithoutIndex#293

Closed
devnaumov wants to merge 3 commits intodevelfrom
fix/multiselection
Closed

fix(plugin-data-spreadsheet-new): CB-757 add getColumnsWithoutIndex#293
devnaumov wants to merge 3 commits intodevelfrom
fix/multiselection

Conversation

@devnaumov
Copy link
Copy Markdown
Member

No description provided.

@devnaumov devnaumov requested a review from Wroud February 19, 2021 22:10
Comment on lines +44 to 47
if (!temporary && firstRowIdx === lastRowIdx && isSelected) {
selectedCells.delete(firstRowIdx);
return;
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange logic

isIndexColumn: (columnKey: string) => boolean;
isIndexColumnInRange: (columnsRange: Array<Column<any[], any>>) => boolean;
getColumnKeyFromColumnIndex: (columnIndex: number) => string;
getColumnsWithoutIndex: () => Array<Column<any[], any>>;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getColumnsWithoutIndex => getDataColumns

@Wroud Wroud closed this Mar 12, 2021
@Wroud
Copy link
Copy Markdown
Member

Wroud commented Mar 12, 2021

no more actual

@devnaumov devnaumov deleted the fix/multiselection branch March 16, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants