Conversation
… driver authorization
Wroud
approved these changes
Oct 8, 2024
…als-is-not-marked-for-auth-even-if-it-is-saved
devnaumov
reviewed
Oct 9, 2024
| for (const id of this.networkHandlers) { | ||
| const handler = connection.networkHandlersConfig.find(handler => handler.id === id); | ||
|
|
||
| if (handler && (handler.userName || handler.authType !== NetworkHandlerAuthType.Password)) { |
Member
There was a problem hiding this comment.
What changed? Why don't we want this check anymore?
Contributor
Author
There was a problem hiding this comment.
cause it does not apply for SSL (no username and NetworkHandlerAuthType.Password)
see the last attached case to the ticket in the comments
Contributor
Author
There was a problem hiding this comment.
reverted this logic. we need to groom this form in general cause it has several issues with SSH and SSL fields (created tickets for that)
…als-is-not-marked-for-auth-even-if-it-is-saved
This reverts commit e25fc3b.
Wroud
deleted the
CB-5563-te-change-credentials-save-credentials-is-not-marked-for-auth-even-if-it-is-saved
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.