CB-5640-update-fileds-ui-for-dark-and-light-themes#2985
Merged
Conversation
Wroud
requested changes
Oct 9, 2024
| } | ||
|
|
||
| .input[disabled] + .iconContainer { | ||
| .input[aria-disabled='true'] + .iconContainer { |
Member
There was a problem hiding this comment.
i think it's better to keep both selectors
Comment on lines
15
to
17
|
|
||
| &[disabled] { | ||
| &[aria-disabled='true'] { | ||
| opacity: 1; | ||
| } |
Comment on lines
-11
to
-12
| cursor: text; | ||
| pointer-events: none; | ||
| cursor: default; | ||
| opacity: 0.5; |
Member
There was a problem hiding this comment.
this attributes can be on any element, we sure that we want to have 'text' cursor on each? (for example buttons, menu items)
Comment on lines
+127
to
+129
| disabled={false} | ||
| aria-disabled={rest.disabled} | ||
| readOnly={rest.readOnly} |
Member
There was a problem hiding this comment.
can you please explain why we using this behaviour?
Wroud
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.