CB-4066 Migrate Team form to form template#3196
Merged
Conversation
Wroud
requested changes
Jan 21, 2025
Wroud
requested changes
Jan 21, 2025
Wroud
approved these changes
Jan 22, 2025
devnaumov
approved these changes
Jan 22, 2025
| contexts: IExecutionContextProvider<IFormState<ITeamFormState>>, | ||
| ): Promise<void> { | ||
| if (!this.formState.state.teamId) { | ||
| return; |
| this.state.grantedSubjects = this.state.grantedSubjects.filter(subject => !subjectIds.includes(subject)); | ||
| } | ||
|
|
||
| private getConnectionsDifferences(current: string[], next: string[]): { connectionsToRevoke: string[]; connectionsToGrant: string[] } { |
Member
There was a problem hiding this comment.
Differences sound strange, maybe Updates?
Wroud
approved these changes
Jan 27, 2025
kkapper
pushed a commit
to PlaidCloud/cloudbeaver
that referenced
this pull request
Apr 18, 2025
* CB-4066 refactors team structure * CB-4066 refactors Team form to use new API * CB-4066 adds TeamProjects form part to the TeamsForm * CB-4066 cleanup * CB-4066 cleanup * CB-4066 pr fixes * CB-4066 pr fixes * CB-4066 fixes title and error key for team creation * CB-4066 qa fixes * CB-4066 qa fixes * CB-4066 fixes bug with team editing * CB-3753 pr fixes * CB-4066 fixes validation error with wrong teamId --------- Co-authored-by: mr-anton-t <42037741+mr-anton-t@users.noreply.github.com> Co-authored-by: Evgenia <139753579+EvgeniaBzzz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.