dbeaver/pro#5394 feat: null and boolean formatter for base grid#3359
Merged
dbeaver/pro#5394 feat: null and boolean formatter for base grid#3359
Conversation
SychevAndrey
previously approved these changes
Apr 2, 2025
SychevAndrey
requested changes
Apr 7, 2025
|
|
||
| export function NullFormatter({ className, onClick }: Props) { | ||
| return ( | ||
| <span className={clsx(styles['nullValue'], className)} onClick={onClick}> |
Contributor
There was a problem hiding this comment.
don't we want to use tailwind for that kind of styling (simple)
| return <NullFormatter className={className} onClick={onClick} />; | ||
| } | ||
| return ( | ||
| <div style={{ textAlign: 'right' }} className={className} onClick={onClick}> |
Contributor
There was a problem hiding this comment.
not css module, but inline styles. It's better to use tailwind here as well
Comment on lines
+9
to
+10
| "./*.css": "./src/*.css", | ||
| "./*": "./lib/*.js" |
Contributor
There was a problem hiding this comment.
Why should we expose inner js files? Everything needed exported from index.js. And *.css basically the index.css, we can define it here strictly.
SychevAndrey
approved these changes
Apr 8, 2025
kkapper
pushed a commit
to PlaidCloud/cloudbeaver
that referenced
this pull request
Apr 18, 2025
…ver#3359) * dbeaver/pro#5394 feat: null and boolean formatter for base grid * feat: reuse base grid formatters * chore: try to adjust workflow concurrency * chore: trigger workflow * chore: trigger workflow cancel * chore: fix label styles --------- Co-authored-by: mr-anton-t <42037741+mr-anton-t@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes dbeaver/pro#5394