Conversation
…stive technologies
…nd add aria-label for accessibility even with linked label, voiceOver doesn't pronounce label when focusing textarea, that's why aria-label is used there
aria-live polite works with aria regions which initially empty and then dynamically populated with some data. If we want assistive technologies read initial content, we need to use alert role. also hide icon from assistive technologies (no additional information from that)
sergeyteleshev
previously approved these changes
Jul 15, 2025
Wroud
reviewed
Jul 15, 2025
Wroud
previously approved these changes
Jul 16, 2025
Wroud
previously approved these changes
Jul 17, 2025
use native htmlFor
82da2e6 to
f37c559
Compare
Wroud
approved these changes
Jul 18, 2025
devnaumov
approved these changes
Jul 21, 2025
sergeyteleshev
approved these changes
Jul 21, 2025
…e-fields-in-the-application
…e-fields-in-the-application
…e-fields-in-the-application
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed input component, linked controls with labels in field via for attribute.
This approach doesn't work for 100% in all assistive software, that's why I also defined aria-label for inputs as well.