dbeaver/dbeaver#11439 Use getLargeUpdateCount for rows update by default#359
Merged
serge-rider merged 1 commit intodbeaver:develfrom Apr 29, 2021
ShadelessFox:model-statement-large-query-count#ce11439
Merged
dbeaver/dbeaver#11439 Use getLargeUpdateCount for rows update by default#359serge-rider merged 1 commit intodbeaver:develfrom ShadelessFox:model-statement-large-query-count#ce11439
serge-rider merged 1 commit intodbeaver:develfrom
ShadelessFox:model-statement-large-query-count#ce11439
Conversation
Wroud
reviewed
Apr 29, 2021
Comment on lines
493
to
496
| } else { | ||
| int updateRowCount = dbStat.getUpdateRowCount(); | ||
| long updateRowCount = dbStat.getUpdateRowCount(); | ||
| if (updateRowCount >= 0) { | ||
| results.setUpdateRowCount(updateRowCount); | ||
| } else { |
Member
There was a problem hiding this comment.
is this value sent to the frontend? (js supports numbers in the range -(2^53 - 1) to 2^53 - 1)
Member
Author
There was a problem hiding this comment.
I believe so.
The model already accepts long which is 64-bit integer (-263 to 263-1). Perhaps you should handle this case then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.