Merged
Conversation
devnaumov
previously approved these changes
Feb 5, 2026
| existingConnections.map(c => c.name), | ||
| ); | ||
|
|
||
| if (!connection.nodePath) { |
Member
There was a problem hiding this comment.
Its strange that we are relying on the nodePath and its optional, probably we need a new method where we can use connection Id to clone it
HocKu7
previously approved these changes
Feb 6, 2026
SychevAndrey
reviewed
Feb 9, 2026
devnaumov
reviewed
Feb 9, 2026
devnaumov
requested changes
Feb 9, 2026
Wroud
reviewed
Feb 9, 2026
Comment on lines
+169
to
+170
| // Load all connections for the project first to ensure we have them all to generate a unique name for the cloned connection | ||
| const projectConnections = await this.connectionInfoResource.load(ConnectionInfoProjectKey(connection.projectId)); |
Member
There was a problem hiding this comment.
This is possibly a heavy operation; maybe we should pass it to the backend side, so we can call the clone method without specifying the name, and the backend will choose the right one
Contributor
Author
There was a problem hiding this comment.
we've talked about it on standup call. backend said this is not a heavy calculation
devnaumov
previously approved these changes
Feb 9, 2026
devnaumov
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/6998