Skip to content

[CB] The generated Custom SSL certificate domain is not displayed#4127

Merged
serge-rider merged 5 commits intodevelfrom
8305-cb-the-generated-custom-ssl-certificate-domain-is-not-displayed
Feb 18, 2026
Merged

[CB] The generated Custom SSL certificate domain is not displayed#4127
serge-rider merged 5 commits intodevelfrom
8305-cb-the-generated-custom-ssl-certificate-domain-is-not-displayed

Conversation

@sergeyteleshev
Copy link
Copy Markdown
Contributor

@sergeyteleshev sergeyteleshev self-assigned this Feb 10, 2026
@sergeyteleshev sergeyteleshev marked this pull request as ready for review February 10, 2026 15:43
SychevAndrey
SychevAndrey previously approved these changes Feb 11, 2026
import type { ServerConfig } from './ServerConfigResource.js';

// backend sorts supported hosts by priority, so the first one is the default domain
export function getCurrentDomain(serverConfig: ServerConfig | null): string | null {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead you can add it as a getter in the server config resource (it already has such getters for some fields)

@serge-rider serge-rider merged commit a0e6154 into devel Feb 18, 2026
10 checks passed
@serge-rider serge-rider deleted the 8305-cb-the-generated-custom-ssl-certificate-domain-is-not-displayed branch March 10, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants