[CB] Error in the console when opening the admin panel#4194
Merged
Conversation
devnaumov
reviewed
Mar 5, 2026
| } | ||
|
|
||
| create(): IFormState<null> { | ||
| open(): IFormState<null> { |
Member
There was a problem hiding this comment.
We are not opening anything here, we are creating formState instance here, why change name to open?
Usually you need to create separate method in service, name it open and call create from stateManager.create from there. Manager is just for state, it does not know anything about panels and etc so cant have open method
Wroud
requested changes
Mar 5, 2026
| const configurationWizardService = useService(ConfigurationWizardService); | ||
|
|
||
| const formState = serverConfigurationFormStateManager.formState!; | ||
| const formState = serverConfigurationFormStateManager.open(); |
Member
There was a problem hiding this comment.
i think you need to remove ! and change logic to respect that fact that formState might be not initialized, you can do it by moving all dependent logic into different component that will accept formState as a prop and in this component you will display some message instead of form
SychevAndrey
approved these changes
Mar 10, 2026
Wroud
approved these changes
Mar 11, 2026
devnaumov
approved these changes
Mar 11, 2026
devnaumov
deleted the
5495-cb-error-in-the-console-when-opening-the-admin-panel
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/5495