Skip to content

fix(plugin-data-viewer): CB-1129 handle readonly boolean representati…#435

Merged
Wroud merged 2 commits intodevelfrom
fix/readonly-boolean-representation
Aug 6, 2021
Merged

fix(plugin-data-viewer): CB-1129 handle readonly boolean representati…#435
Wroud merged 2 commits intodevelfrom
fix/readonly-boolean-representation

Conversation

@devnaumov
Copy link
Copy Markdown
Member

…on state

@devnaumov devnaumov requested a review from Wroud August 5, 2021 17:08
@devnaumov devnaumov self-assigned this Aug 5, 2021
Comment on lines +36 to +40
&:global([disabled]),
&:global([readonly]) {
opacity: 0.8;
&[type="text"] {
&:global([disabled]),
&:global([readonly]) {
opacity: 0.8;
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably affects too many places, better to revert and make a fix for a specific place

some-selector {
  opacity: 1 !important;
}

@Wroud Wroud merged commit 1c03359 into devel Aug 6, 2021
@devnaumov devnaumov deleted the fix/readonly-boolean-representation branch August 9, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants