Merged
Conversation
# Conflicts: # webapp/packages/core/src/sdk/sdk.ts
Wroud
requested changes
May 28, 2020
| isPresent(context) { | ||
| return context.contextType === NavigationTreeContextMenuService.nodeContextType; | ||
| }, | ||
| order: 1000, |
Member
There was a problem hiding this comment.
better to use Number.MAX_SAFE_INTEGER
| } | ||
|
|
||
| async refreshNode(nodeId: string) { | ||
| console.log('refresh', nodeId); |
Comment on lines
+86
to
+87
| this.nodesStore.removeNode(nodeId); | ||
| await this.updateNodeInfo(nodeId); |
Member
There was a problem hiding this comment.
remove can cause many bugs in case of an update, so we probably must check the result of request inside updateNodeInfo and remove node if it does not exist anymore, on other cases we probably just update node related data
Wroud
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.