Skip to content

Enhance build script#843

Closed
pan3793 wants to merge 1 commit intodbeaver:develfrom
pan3793:script
Closed

Enhance build script#843
pan3793 wants to merge 1 commit intodbeaver:develfrom
pan3793:script

Conversation

@pan3793
Copy link
Copy Markdown
Contributor

@pan3793 pan3793 commented May 22, 2022

Currently, user must run cd deploy before building the project.

This PR enhances the build script to make build script can run from any folder.

PS: I don't touch bat because I am not familiar with that language and don't have Windows machine to test.

Comment thread deploy/build.sh
cp -rp ${PROJECT_HOME}/webapp/packages/product-default/lib/* ${PROJECT_HOME}/deploy/cloudbeaver/web

echo "Cloudbeaver is ready. Run run-server.bat in cloudbeaver folder to start the server."
echo "Cloudbeaver is ready. Run run-server.sh in ${PROJECT_HOME}/deploy/cloudbeaver folder to start the server."
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change run-server.bat to run-server.sh

@pan3793 pan3793 mentioned this pull request May 26, 2022
@LonwoLonwo
Copy link
Copy Markdown
Member

Hello @pan3793

Thanks for your contribution!
Sorry, we missed it.

In general, your idea is normal.
But, unfortunately, it will not work on all OS. And it is critical because CloudBeaver must be available for all OS.

So, I'm closing this PR.
But you are always welcome with new ideas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external For external PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants