Skip to content

Assume metres for unlabeled DEM elevations#7

Merged
dbech merged 1 commit into
mainfrom
codex/fresnel-unlabeled-elevation
May 24, 2026
Merged

Assume metres for unlabeled DEM elevations#7
dbech merged 1 commit into
mainfrom
codex/fresnel-unlabeled-elevation

Conversation

@dbech
Copy link
Copy Markdown
Owner

@dbech dbech commented May 23, 2026

Summary

  • Treat blank/unknown DEM elevation units as metres for Fresnel rendering instead of hiding the overlay
  • Keep the explicit warning so users know unlabeled elevation values are assumed to be metres
  • Bump the package version to 0.1.5 so the release workflow builds this bug fix

Root Cause

The Fresnel unit-normalization fix correctly blocked unsupported elevation units, but many DEMs do not populate RasterBand.unitType even when their elevation values are metre-scale. That made Fresnel controls disappear for otherwise valid projected metre datasets.

Validation

  • bun install --frozen-lockfile
  • bun run test:unit
  • bun run typecheck
  • bun run lint
  • bun run format:check
  • git diff --check
  • bun run build

@dbech
Copy link
Copy Markdown
Owner Author

dbech commented May 24, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dbech dbech merged commit 96380a5 into main May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant