-
Notifications
You must be signed in to change notification settings - Fork 40
Update processDelayFiles.py #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tools/RAiDER/cli/raider.py
Outdated
| gunw_id = args.file.name.replace('.nc', '') | ||
| weather_model_name = identify_which_hrrr(args.file) | ||
| if not RAiDER.aria.prepFromGUNW.check_hrrr_dataset_availablity_for_s1_azimuth_time_interpolation(gunw_id, weather_model_name): | ||
| if not RAiDER.aria.prepFromGUNW.check_hrrr_dataset_availablity_for_s1_azimuth_time_interpolation(gunw_id): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sssangha this seems like an odd change for this PR. Was this causing an error for you due to a change in the underlying function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, this was associated with some divergence in my local code from a previous version of the code.
I've updated this to remove such divergence.
jlmaurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sssangha everything looks good to me except for the one comment I left.
Update building off of PR 784.
Added support in the
raiderCombine.pyworkflow to automatically compute and capture within a separate CSV file "*_WM_variance.csv" the uncertainty of the input weather model, defined assigma_model = sqrt(sigma_res^2 - sigma_gnss^2), wheresigma_res^2=E{(ZTDgnss - ZTDwm)^2}. Additional columns forsigma_res,sigma_gnss,mean bias, andsigma_meanbiassalso passed.This analysis is done across all time-observations for a given station, so I made some minor adjustments to the statistical analysis call to handle this file appropriately (i.e. avoid averaging in time when the time dimension collapses).
I also include support to remove GNSS stations with sigZTD values above a specified threshold with the
--obs_errlimitoption. This option was originally only supported throughraiderStats.pyon the final CSV file, but not including this option in theraiderCombine.pystage would've led to a misleading time-averages as bad stations would get included in the uncertainty calculations.Screenshots (if appropriate):
Type of change
Checklist: