Skip to content

Conversation

@sssangha
Copy link
Collaborator

Update building off of PR 784.

Added support in the raiderCombine.py workflow to automatically compute and capture within a separate CSV file "*_WM_variance.csv" the uncertainty of the input weather model, defined as sigma_model = sqrt(sigma_res^2 - sigma_gnss^2), where sigma_res^2=E{(ZTDgnss - ZTDwm)^2}. Additional columns for sigma_res, sigma_gnss, mean bias, and sigma_meanbiass also passed.

This analysis is done across all time-observations for a given station, so I made some minor adjustments to the statistical analysis call to handle this file appropriately (i.e. avoid averaging in time when the time dimension collapses).

I also include support to remove GNSS stations with sigZTD values above a specified threshold with the --obs_errlimit option. This option was originally only supported through raiderStats.py on the final CSV file, but not including this option in the raiderCombine.py stage would've led to a misleading time-averages as bad stations would get included in the uncertainty calculations.

Screenshots (if appropriate):

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sssangha sssangha marked this pull request as ready for review November 25, 2025 01:20
@sssangha sssangha requested a review from jlmaurer November 25, 2025 01:20
gunw_id = args.file.name.replace('.nc', '')
weather_model_name = identify_which_hrrr(args.file)
if not RAiDER.aria.prepFromGUNW.check_hrrr_dataset_availablity_for_s1_azimuth_time_interpolation(gunw_id, weather_model_name):
if not RAiDER.aria.prepFromGUNW.check_hrrr_dataset_availablity_for_s1_azimuth_time_interpolation(gunw_id):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sssangha this seems like an odd change for this PR. Was this causing an error for you due to a change in the underlying function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, this was associated with some divergence in my local code from a previous version of the code.

I've updated this to remove such divergence.

Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sssangha everything looks good to me except for the one comment I left.

@sssangha
Copy link
Collaborator Author

sssangha commented Dec 1, 2025

@sssangha everything looks good to me except for the one comment I left.

@jlmaurer sounds good! I cleaned up some local code divergence + made more clear comments regarding the equations following our meeting.

@jlmaurer jlmaurer merged commit 469832d into dev Dec 2, 2025
8 of 9 checks passed
@sssangha sssangha deleted the weather_model_sigma branch December 4, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants