Planning for Validation Tasks and Unit Test Cases

[dbera]

Sprint 1

• Name of global model should not have underscores. [Samira + Yuri]
• Only alphanumerical and space is allowed, and not starting with a digit
• See also https://ci.tno.nl/gitlab/debjyoti.bera-tno/bpmn4s-editor/-/issues/77
• Run step must always have step type. [Samira + Yuri]
• See also https://ci.tno.nl/gitlab/debjyoti.bera-tno/bpmn4s-editor/-/issues/77
• A system block may have many RUN steps but they all must be of the same step-type. [Samira]
• Investigate why is this the case? [Deb]
• Guards validations: Currently any record to record comparison type-passes, no matter the type of the record. You can actually compare anything you want, for instance a record against an integer. Prevent this by checking LHS and RHS type. [Samira]
• Double check on pre-defined functions in update/ref expressions
• Setup unit test packages for Product package and enable test runs on CI/CD [Yuri]
• Create complex version of 3D PrintShop model [Samira] To be revisited and completed Add nested compose steps
• Create first unit test for BPMN4S to PSpec generation with old printshop model [Samira]
• Checks only number and types of files produced

[dbera]

Sprint 2

• Add unit tests for PSpec - abstract TSpec using the 3D Printshop model [first resolve open issue from Sprint 1] - (Samira)

• Null values feature: To be added as expression to the language. For python code "SankesHelper.xtend" this must be assigned to None. Also default constructors must ensure that all fields are assigned either concrete or null value. Add validations to abstract tspec: multiple duplicated consumes from field. (Yuri)

• Validation Update expressions should only assign the involved output (no input or other output). (To be validated - Samira)

• Validation In abstract tspec, multiple consumes from field having the same data is not allowed. Flag as error/warning (to be discussed - Samira)

• Discussions When you omit a field in a token initialization and you want to fetch that field later, maybe when assigning that token to another, snakes fails. We need to think what to do here. Do we want a validation? do we want to allow the users to omit fields and overcome the issue in the CPN code? Solution Enforce that all fields of a record constructor initializes all its fields (currently there is a validation that checks at least one field must be present, this needs to be changed). Problem Task updates: Reference to RUN task outputs should only be mentioned in the reference section. Unless we want to unify concrete, reference and maybe even symbolic in a single update and anyways resolve the linking. Current issue is that if you use a reference to a RUN task output in the concrete update, then it is not linked. Solution (Be able to mark record fields in the type def. as symbolic and enforce throughout the model) Also in the simulation, show the user symbolic/concrete representations - Plan meeting 18th Aug: Yuri, Deb, Samira (new feature) Validation fields marked as symbolic may not be used in guards or update expressions.

• Validation Enforce that all fields of a record constructor initializes all its fields except symbolic.

• Content Assist The default constructor must initialize all fields of a record (nested) except symbolic - [Yuri]

• Important If the modeler does not provide an update expression for an output variable, currently PSpec to Python calls the SnakesHelper to auto initialize all its fields. This should be restricted to non-symbolic fields - [Yuri]

• Validation All fields of a record cannot be marked symbolic.

• Validation Variables that are symbolic may not be used in guards or update expressions. They may only be used in assertions or in reference expressions. Variables that are not symbolic may not be used in reference expressions. They maybe used in assertions.

• Content Assist Add assist to suppress symbolic variables in guards and update expressions. Add assist to suppress non-symbolic variables in reference expressions.

• Validation Enforce 2 types of assignments to record variables. A field of a record may be assigned a value if and only if the record variable itself was initialized either with a default constructor or through variable copy - 3 (Samira). Note validation must scope from actionList in updates part of grammar (belongs to product validations). Parse the list only once for each update field.

[dbera]

This is ok.

[dbera]

This is ok

[dbera]

This is not Okay