Skip to content

Update to maintained Ruby version 2.7.6#114

Closed
agrberg wants to merge 2 commits intodblock:masterfrom
agrberg:update_to_supported_ruby
Closed

Update to maintained Ruby version 2.7.6#114
agrberg wants to merge 2 commits intodblock:masterfrom
agrberg:update_to_supported_ruby

Conversation

@agrberg
Copy link
Copy Markdown
Collaborator

@agrberg agrberg commented Jul 21, 2022

Built on top of an intended to be merged after #113

Now built on top of #117 to restore CI and then update to a maintained Ruby.

resolves #115

Copy link
Copy Markdown
Owner

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see many benefits to making Ruby 2.7 the minimum. Maybe we can keep it at 2.4? 2.6? for now? Either way we need CI back to see what's possible #116

Comment thread .rubocop.yml
Comment thread .rubocop.yml
Comment thread UPGRADING.md Outdated
Comment thread iex-ruby-client.gemspec Outdated
Comment thread iex-ruby-client.gemspec
Comment thread iex-ruby-client.gemspec Outdated
@agrberg agrberg force-pushed the update_to_supported_ruby branch 2 times, most recently from 4815ad8 to ec4020f Compare July 21, 2022 19:30
@agrberg
Copy link
Copy Markdown
Collaborator Author

agrberg commented Jul 21, 2022

I don't see many benefits to making Ruby 2.7 the minimum. Maybe we can keep it at 2.4? 2.6? for now? Either way we need CI back to see what's possible #116

Good call regarding CI. It wasn't straightforward but it ended up being some minimal changes. I rebased this on #117 and split up the commits into an incredibly minimal 3f9cc20 to update the Ruby version. After this, I'd agree it would be good enough to keep on Ruby 2.4.

Now e8fc984 contains the safer changes and rubocop todo updates as well as additional current locks on the dev dependencies.

Edit: Updated the commits post rebase of #117 to keep things fresh and ready

@dblock
Copy link
Copy Markdown
Owner

dblock commented Jul 22, 2022

Thanks so much for all of this! Let's get the CI to pass and cleanup the rest of the PRs.

@agrberg agrberg force-pushed the update_to_supported_ruby branch from ec4020f to e8fc984 Compare July 22, 2022 13:06
@dblock
Copy link
Copy Markdown
Owner

dblock commented Jul 22, 2022

Rebase this one and let's re-review?

@agrberg agrberg force-pushed the update_to_supported_ruby branch from e8fc984 to 7b4668a Compare July 22, 2022 18:03
* `rubocop -a` updates
* `rubocop --auto-gen-config` new todo.yml
* pessimistically lock dev dependencies on major version w/ latest minor specified
* add exception for lines > 120 chars that contain trailing comments
@agrberg agrberg force-pushed the update_to_supported_ruby branch from 7b4668a to f72ba43 Compare July 22, 2022 18:08
@agrberg agrberg requested a review from dblock July 22, 2022 18:09
@agrberg
Copy link
Copy Markdown
Collaborator Author

agrberg commented Jul 22, 2022

This one is ready but it still depends on the question of whether or not we want to restrict the library to only maintained versions of Ruby. The Rubocop updates are nice but hardly required.

FWIW It looks like the token I copied from your Slack client project doesn't have write access to the project. While the output is not familiar, it appears to be successful and simply unable to state that it is successful via a PR comment.

@dblock
Copy link
Copy Markdown
Owner

dblock commented Jul 23, 2022

This one is ready but it still depends on the question of whether or not we want to restrict the library to only maintained versions of Ruby. The Rubocop updates are nice but hardly required.

I think I'd rather not restrict the library unnecessarily just to make rubocop happy, it's bound to make someone unhappy, I'm still on 2.6.x for example in at least one project that uses this. WDYT?

I think CI should only run rubocop once (which can be on ruby >= 2.7), the rubocop target version can be set to 2.4, and version-specific CI would run the range of supported rubies via rake spec?

FWIW It looks like the token I copied from your Slack client project doesn't have write access to the project. While the output is not familiar, it appears to be successful and simply unable to state that it is successful via a PR comment.

I opened #118, we can deal with it later. Danger isn't supposed to need write access, it just needs to be able to comment on the PRs, which is something any account (and therefore this super limited PAT) can do.

@agrberg
Copy link
Copy Markdown
Collaborator Author

agrberg commented Jul 23, 2022

I agree. Going to close this. We'll revisit minimum Ruby version if there's a forward facing problem in the future like all the kwarg changes for Ruby 3.

@agrberg agrberg closed this Jul 23, 2022
@agrberg agrberg deleted the update_to_supported_ruby branch July 23, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rubies < 2.7.6 are EOL

2 participants