Skip to content

Add Earnings Resource#27

Merged
dblock merged 1 commit intodblock:masterfrom
rodolfobandeira:add-earnings-resources
Aug 15, 2018
Merged

Add Earnings Resource#27
dblock merged 1 commit intodblock:masterfrom
rodolfobandeira:add-earnings-resources

Conversation

@rodolfobandeira
Copy link
Copy Markdown
Collaborator

close #25

@rodolfobandeira
Copy link
Copy Markdown
Collaborator Author

@dblock Despite the fact it is passing on Travis, I have price_spec failing on my local machine. I'm not sure if you're getting the same thing? Would you mind to please confirm that?

Here is my log:

  1) IEX::Resources::Price known symbol retrieves a price
     Failure/Error: super JSON.parse(response[:body])['error']

     TypeError:
       no implicit conversion of nil into String
     # ./lib/iex/errors/client_error.rb:8:in `initialize'
     # ./lib/iex/resources/base.rb:9:in `exception'
     # ./lib/iex/resources/base.rb:9:in `raise'
     # ./lib/iex/resources/base.rb:9:in `rescue in symbol'
     # ./lib/iex/resources/base.rb:5:in `symbol'
     # ./lib/iex/resources/price.rb:7:in `get'
     # ./spec/iex/resources/price_spec.rb:6:in `block (3 levels) in <top (required)>'
     # ./spec/iex/resources/price_spec.rb:9:in `block (3 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # Faraday::ParsingError:
     #   784: unexpected token at '93.78'
     #   ./lib/iex/api/price.rb:5:in `get'

Finished in 2.1 seconds (files took 0.3974 seconds to load)
49 examples, 1 failure

@rodolfobandeira rodolfobandeira requested a review from dblock August 15, 2018 02:15
@dblock dblock merged commit 275afea into dblock:master Aug 15, 2018
@dblock
Copy link
Copy Markdown
Owner

dblock commented Aug 15, 2018

LGTM, not sure what your local problem is, passes for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Earnings Resource

2 participants