Sectors performance#32
Sectors performance#32rodolfobandeira merged 10 commits intodblock:masterfrom gil27:fetch-sector-performance
Conversation
The following code implements support to fetch sectors peformance from api. It implements the feature inside `lib/iex/api/sectors`. For more information check it out: #31
|
Looks good. See bot comments above about the TOC and CHANGELOG. |
rodolfobandeira
left a comment
rodolfobandeira
left a comment
There was a problem hiding this comment.
@gil27 Looks pretty good. Just added a few suggestions. Also. please add your name and description of your feature on CHANGELOG.md. Instruction here: https://github.com/dblock/iex-ruby-client/blob/master/CONTRIBUTING.md#update-changelog
| Fetches earnings for a symbol. | ||
|
|
||
| ```ruby | ||
| earnings = IEX::Resources::Earnings.get('MSFT') |
There was a problem hiding this comment.
@gil27 This should be: sectors = IEX::Resources::Sectors.get('MSFT')
|
Guys, I have been beat by |
|
Hey @gil27 Please try this:
|
|
|
||
| ### Get Sector Performance | ||
|
|
||
| Fetches earnings for a symbol. |
There was a problem hiding this comment.
Missed this one. It should be something like: Fetches latest sector's performance.
|
Your missing a colon after the issue number in CHANGELOG: |
rodolfobandeira
left a comment
rodolfobandeira
left a comment
There was a problem hiding this comment.
Looks good to me!
@dblock What do you think?
|
@rodolfobandeira you can merge at will, no need to ask me ;) |
| ### 0.5.0 (next) | ||
| * Your contribution here. | ||
|
|
||
| ### 0.4.4 (2018/10/03) |
There was a problem hiding this comment.
We haven't released 0.4.4, please undo this change, it should just be 0.4.4 next.
| Fetches latest sector's performance. | ||
|
|
||
| ```ruby | ||
| sectors = EX::Resources::Sectors.get('MARKET') |
|
|
||
| ### 0.4.3 (2018/08/18) | ||
|
|
||
| * Your contribution here. |
There was a problem hiding this comment.
That one has shipped, I'll edit in master.
3 participants
Hello, guys. This PR address issue #31
I've tried to follow the code style, and be simple.
By the way, you guys have a good code base. 👍 👍 👍
The following code implements support to fetch sectors performance from
api.
It implements the feature inside
lib/iex/api/sectors.I'm looking forward your review