Skip to content

Updates on largest-trades#36

Merged
dblock merged 3 commits intomasterfrom
fix-largest-trades
Oct 17, 2018
Merged

Updates on largest-trades#36
dblock merged 3 commits intomasterfrom
fix-largest-trades

Conversation

@rodolfobandeira
Copy link
Copy Markdown
Collaborator

@rodolfobandeira rodolfobandeira commented Oct 16, 2018

closes #35

@gil27
@dblock

CHANGELOG.md Outdated
@@ -1,5 +1,6 @@
### 0.4.4 (next)

* [#36](https://github.com/dblock/iex-ruby-client/pull/36): Updates on largest-trades - [@rodolfobandeira](https://github.com/rodolfobandeira).
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we haven't shipped the largest trades stuff yet, no need to include this.

Copy link
Copy Markdown
Collaborator Author

@rodolfobandeira rodolfobandeira Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danger-toc was complaining about it.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblock Rolled-back

@dangerpr-bot
Copy link
Copy Markdown

1 Warning
⚠️ Unless you’re refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#36](https://github.com/dblock/iex-ruby-client/pull/36): Updates on largest-trades - [@rodolfobandeira](https://github.com/rodolfobandeira).

Generated by 🚫 Danger

@dblock dblock merged commit 6bad455 into master Oct 17, 2018
@dblock
Copy link
Copy Markdown
Owner

dblock commented Oct 17, 2018

👍

@rodolfobandeira rodolfobandeira deleted the fix-largest-trades branch October 17, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double check "largest-trades" behavior when multiple trades are returned

3 participants