Merged
Conversation
Generated by 🚫 Danger |
bguban
force-pushed
the
fix_ref_data_isin
branch
from
ed795b5 to
a08489d
Compare
bguban
force-pushed
the
fix_ref_data_isin
branch
from
a08489d to
624833c
Compare
| module RefData | ||
| def ref_data_isin(isins, options = {}) | ||
| response = post('ref-data/isin', { token: publishable_token, isin: isins }.merge(options)) | ||
| response = get('ref-data/isin', { token: publishable_token, isin: isins.join(',') }.merge(options)) |
Collaborator
There was a problem hiding this comment.
What do you think about adding a check to see if isins is indeed an array? If you pass a string for isins it will blow up
Owner
There was a problem hiding this comment.
I would Array(isins) to allow a single ASIN without having to do any work.
dblock
approved these changes
Apr 10, 2020
Owner
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
I'm ok with this, but feel free to make the Array change on top.
| module RefData | ||
| def ref_data_isin(isins, options = {}) | ||
| response = post('ref-data/isin', { token: publishable_token, isin: isins }.merge(options)) | ||
| response = get('ref-data/isin', { token: publishable_token, isin: isins.join(',') }.merge(options)) |
Owner
There was a problem hiding this comment.
I would Array(isins) to allow a single ASIN without having to do any work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IEX cloud changed its endpoint https://iexcloud.io/docs/api/#isin-mapping. Now they expect GET requests instead of POST.
