Conversation
agrberg
force-pushed
the
add_http_referer
branch
2 times, most recently
from
1297446 to
54e1d8a
Compare
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
I definitely don't think we should be correcting spelling for Referer, The https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referer doc is clearly calling this with 1 R and everybody is happy to perpetuate this mistake to avoid confusion.
| open_timeout | Optional connection open timeout in seconds. | ||
| publishable_token | IEX Cloud API publishable token. | ||
| endpoint | Defaults to `https://cloud.iexapis.com/v1`. | ||
| referrer | Optional string for HTTP `Referer` header, enables token domain management. |
There was a problem hiding this comment.
|
.. btw I can be convinced otherwise with referrer vs. referer if other clients correct this, but I see referer everywhere, including AWS docs |
agrberg
force-pushed
the
add_http_referer
branch
from
54e1d8a to
ca706ff
Compare
|
I honestly didn't know so I felt that on the human API layer it could be spelled properly and only translated at the last moment to the canonized misspelling. I also think that anyone messing around with the |
|
Thanks! |
2 participants
Enables passing in a
refererconfiguration option to set the HTTPRefererheader. This is necessary to lock tokens to a domain.There weren't tests for each individual configuration variable, default, or headers (testing Faraday's API maybe?) so I wasn't sure what to add. I can confirm it works in actual usage in my app and that
bundle exec rakeruns clean after all changes too.